gtk4.git
5 years agoinspector: Stop showing settings bindings
Matthias Clasen [Wed, 5 Aug 2020 15:10:22 +0000 (11:10 -0400)]
inspector: Stop showing settings bindings

We were playing fast-and-loose with private GIO data
when showing settings bindings in the property editor,
and this was causing crashes.

We can show this information again if GIO ever gets
api to introspect it.

Fixes: #3015
5 years agoMerge branch 'fix-solid-csd' into 'master'
Matthias Clasen [Wed, 5 Aug 2020 14:13:21 +0000 (14:13 +0000)]
Merge branch 'fix-solid-csd' into 'master'

Adwaita: Reduce the solid csd borders

Closes #2997

See merge request GNOME/gtk!2372

5 years agoMerge branch 'matthiasc/for-master' into 'master'
Matthias Clasen [Wed, 5 Aug 2020 12:48:41 +0000 (12:48 +0000)]
Merge branch 'matthiasc/for-master' into 'master'

testborderdrawing: Don't crash on exit

See merge request GNOME/gtk!2370

5 years agoMerge branch 'gradient-hard-stop-test' into 'master'
Matthias Clasen [Wed, 5 Aug 2020 12:48:30 +0000 (12:48 +0000)]
Merge branch 'gradient-hard-stop-test' into 'master'

Add a reftest for gradients with hard stops

See merge request GNOME/gtk!2371

5 years agoAdwaita: Reduce the solid csd borders
Matthias Clasen [Wed, 5 Aug 2020 12:45:46 +0000 (08:45 -0400)]
Adwaita: Reduce the solid csd borders

Reduce the borders we draw ourselves for solid csd
to 1 pixel. It still doesn't look great, but at least
it doesn't look outright broken.

Fixes: #2997
5 years agotestborderdrawing: Don't crash on exit
Matthias Clasen [Wed, 5 Aug 2020 12:18:07 +0000 (08:18 -0400)]
testborderdrawing: Don't crash on exit

5 years agoAdd a reftest for gradients with hard stops
Matthias Clasen [Wed, 5 Aug 2020 12:09:42 +0000 (08:09 -0400)]
Add a reftest for gradients with hard stops

This is testing the issue described in #1293.

No fix though, this is still broken in Vulkan.
It works correctly in GL and with cairo.

5 years agoMerge branch 'hex-color-parse' into 'master'
Matthias Clasen [Wed, 5 Aug 2020 11:46:55 +0000 (11:46 +0000)]
Merge branch 'hex-color-parse' into 'master'

Hex color parse

Closes #2931

See merge request GNOME/gtk!2356

5 years agoMerge branch 'master.win32' into 'master'
Matthias Clasen [Wed, 5 Aug 2020 11:31:52 +0000 (11:31 +0000)]
Merge branch 'master.win32' into 'master'

Another round of fixes for GDK/Win32

See merge request GNOME/gtk!2369

5 years agoGdkGLContext: Drop gdk_gl_context_has_[framebuffer_blit|frame_terminator]()
Chun-wei Fan [Wed, 5 Aug 2020 10:56:57 +0000 (18:56 +0800)]
GdkGLContext: Drop gdk_gl_context_has_[framebuffer_blit|frame_terminator]()

gdk_gl_context_has_framebuffer_blit() and gdk_gl_context_has_frame_terminator()
were only used by by GDK/Win32, and they do not provide performance advantages
in GTK master, so clean up the code a bit by dropping them.

5 years agotestsuite/gsk: Only run Broadway tests if enabled
Chun-wei Fan [Mon, 3 Aug 2020 08:23:30 +0000 (16:23 +0800)]
testsuite/gsk: Only run Broadway tests if enabled

We may not have enabled building the broadway renderer for our build, so don't
run the broadway renderer tests unless it is enabled.

5 years agotestsuite: Setup tests env by platform
Chun-wei Fan [Mon, 3 Aug 2020 08:14:36 +0000 (16:14 +0800)]
testsuite: Setup tests env by platform

Check whether we really have x11 and wayland enabled before we try to setup the
tests to use these respective GDK backends, and only attempt to setup tests
running with the Broadway backend if it has been enabled.

Also, add a setup for running tests with the GDK-Win32 backend on Windows, for
builds that target Windows.

5 years agogdksurface-win32.c: Fix resizing
Chun-wei Fan [Wed, 5 Aug 2020 07:14:44 +0000 (15:14 +0800)]
gdksurface-win32.c: Fix resizing

Use gdk_surface_get_geometry() to get the correct x and y coordinates of the
window that we are resizing, so that the window does not reposition itself
automatically at the top-left corner at resizing as we to used hard-code the x
and y coordinates to 0.

5 years agogdkvulkancontext-win32.c: Implement ->begin_frame()
Chun-wei Fan [Mon, 3 Aug 2020 10:43:46 +0000 (18:43 +0800)]
gdkvulkancontext-win32.c: Implement ->begin_frame()

By doing so, we ensure that resizes of windows will work on Vulkan renderer, by
first calling gdk_win32_surface_handle_queued_move_resize() before we proceed
as usual

5 years agogdk[cairo|gl]context-win32.c: Use gdk_win32_surface_handle_queued_move_resize()
Chun-wei Fan [Wed, 5 Aug 2020 02:43:11 +0000 (10:43 +0800)]
gdk[cairo|gl]context-win32.c: Use gdk_win32_surface_handle_queued_move_resize()

Use the shared function that was added in the previous commit, to simplify
things.

Also make gdk_win32_surface_get_queued_window_rect() and
gdk_win32_surface_apply_queued_move_resize() back into static functions, since
they are now used only by the code in gdksurface-win32.c

5 years agogdksurface-win32.c: Add function to handle queued moves/resizes
Chun-wei Fan [Wed, 5 Aug 2020 02:36:53 +0000 (10:36 +0800)]
gdksurface-win32.c: Add function to handle queued moves/resizes

Since we need to deal with queued moves and resizes in the Cairo, GL and Vulkan
draw contexts, and the logic involved in all three of these are largely
similar, add a function gdk_win32_surface_handle_queued_move_resize() that will
handle this, which will be shared between these three types of draw contexts.

5 years agoUpdate Galician translation
Fran Dieguez [Wed, 5 Aug 2020 07:56:11 +0000 (07:56 +0000)]
Update Galician translation

5 years agoGDK-Win32: Move some functions around
Chun-wei Fan [Mon, 3 Aug 2020 10:22:51 +0000 (18:22 +0800)]
GDK-Win32: Move some functions around

Move gdk_win32_surface_get_queued_window_rect() and
gdk_win32_surface_apply_queued_move_resize() to gdksurface-win32.c, since these
functions are not only used for Cairo draw contexts, but is also used for GL
draw contexts, and will be used for Vulkan draw contexts.

5 years agogdksurface-win32.c: Fix Aerosnap computation
Chun-wei Fan [Mon, 3 Aug 2020 08:01:40 +0000 (16:01 +0800)]
gdksurface-win32.c: Fix Aerosnap computation

Don't get the default display when we compute the Aerosnap region, but instead
get it from the underlying GdkSurface that we are using for the computation.

Also, don't unref the monitors that we obtain from the display in the wrong
place, which was why we had crashes whenever we triggered AeroSnap code (and we
are actually not supposed to do that as they are owned by the GdkDisplay that
is owned by the GdkSurface we are using), and this will eliminate lots of
criticals that are spewed as a result.

5 years agoMerge branch 'drop-accel-label' into 'master'
Matthias Clasen [Wed, 5 Aug 2020 03:44:43 +0000 (03:44 +0000)]
Merge branch 'drop-accel-label' into 'master'

Drop accel label

See merge request GNOME/gtk!2368

5 years agoMerge branch 'docs-cleanup' into 'master'
Matthias Clasen [Wed, 5 Aug 2020 03:17:06 +0000 (03:17 +0000)]
Merge branch 'docs-cleanup' into 'master'

Docs cleanup

See merge request GNOME/gtk!2367

5 years agoDrop GtkAccelLabel
Matthias Clasen [Wed, 5 Aug 2020 02:23:43 +0000 (22:23 -0400)]
Drop GtkAccelLabel

We no longer use this widget anywhere.

5 years agoDrop GtkCallback
Matthias Clasen [Wed, 5 Aug 2020 02:17:52 +0000 (22:17 -0400)]
Drop GtkCallback

It is no longer used in any of our public APIs.

5 years agoselectionfiltermodel: Drop a leftover symbol
Matthias Clasen [Wed, 5 Aug 2020 02:04:57 +0000 (22:04 -0400)]
selectionfiltermodel: Drop a leftover symbol

We decided not to do new_for_type() for list model
wrappers, so this function does not exist.

5 years agodocs: Clean up many dangling links
Matthias Clasen [Wed, 5 Aug 2020 01:17:49 +0000 (21:17 -0400)]
docs: Clean up many dangling links

In many cases, these were references to no longer
existing api, so some rewording was necessary.

5 years agodocs: Drop GtkPlacesSidebar from visual index
Matthias Clasen [Tue, 4 Aug 2020 23:31:22 +0000 (19:31 -0400)]
docs: Drop GtkPlacesSidebar from visual index

No longer a public widget.

5 years agoUpdate Galician translation
Fran Dieguez [Tue, 4 Aug 2020 22:12:01 +0000 (22:12 +0000)]
Update Galician translation

5 years agoMerge branch 'try-to-fix-xvfb-in-ci' into 'master'
Matthias Clasen [Tue, 4 Aug 2020 16:56:12 +0000 (16:56 +0000)]
Merge branch 'try-to-fix-xvfb-in-ci' into 'master'

ci: Pass -noreset to Xvfb

See merge request GNOME/gtk!2366

5 years agoci: Pass -norest to Xvfb
Matthias Clasen [Tue, 4 Aug 2020 15:59:32 +0000 (11:59 -0400)]
ci: Pass -norest to Xvfb

This may help with the sporadic "No display" failures
we are seeing when running tests under X11 in ci.

5 years agoMerge branch 'popoverflow' into 'master'
Matthias Clasen [Tue, 4 Aug 2020 15:47:50 +0000 (15:47 +0000)]
Merge branch 'popoverflow' into 'master'

popover: Set overflow: hidden

Closes #3012

See merge request GNOME/gtk!2365

5 years agoMerge branch 'a11y-crash' into 'master'
Matthias Clasen [Tue, 4 Aug 2020 15:47:36 +0000 (15:47 +0000)]
Merge branch 'a11y-crash' into 'master'

A11y crash

Closes #3014

See merge request GNOME/gtk!2364

5 years agopopover: Set overflow: hidden
Matthias Clasen [Tue, 4 Aug 2020 15:09:45 +0000 (11:09 -0400)]
popover: Set overflow: hidden

This keeps overlay scrollbars from wrecking our
nice rounded corners.

Fixes: #3012
5 years agoa11y: Don't do unnecessary work
Matthias Clasen [Tue, 4 Aug 2020 15:02:00 +0000 (11:02 -0400)]
a11y: Don't do unnecessary work

Only serialize all the attributes if we are actually
going to print them.

5 years agoscrolledwindow: Fix a11y support code
Matthias Clasen [Tue, 4 Aug 2020 15:00:32 +0000 (11:00 -0400)]
scrolledwindow: Fix a11y support code

This error was introduced by me in 971ee2d28a65b816050c
and causes a crash in the scrolling benchmark in gtk-demo.

Fixes: #3014
5 years agoUpdate Romanian translation
Florentina Mușat [Tue, 4 Aug 2020 11:23:33 +0000 (11:23 +0000)]
Update Romanian translation

5 years agoMerge branch 'modern-doc-shooter' into 'master'
Matthias Clasen [Tue, 4 Aug 2020 11:22:07 +0000 (11:22 +0000)]
Merge branch 'modern-doc-shooter' into 'master'

Modern doc shooter

See merge request GNOME/gtk!2363

5 years agodocs: Add a gallery image for GtkDropDown
Matthias Clasen [Tue, 4 Aug 2020 04:33:37 +0000 (00:33 -0400)]
docs: Add a gallery image for GtkDropDown

5 years agodocs: Add a gallery image for GtkEditableLabel
Matthias Clasen [Tue, 4 Aug 2020 04:25:35 +0000 (00:25 -0400)]
docs: Add a gallery image for GtkEditableLabel

5 years agodocs: Add gallery image for GtkPasswordEntry
Matthias Clasen [Tue, 4 Aug 2020 04:16:22 +0000 (00:16 -0400)]
docs: Add gallery image for GtkPasswordEntry

5 years agodocs: Avoid focus in gallery images
Matthias Clasen [Tue, 4 Aug 2020 04:14:17 +0000 (00:14 -0400)]
docs: Avoid focus in gallery images

Seeing focus rectangles and selections in these
images is a distraction, and we used to avoid it.
Bring that back.

5 years agodocs: Improve the gallery image for scales
Matthias Clasen [Tue, 4 Aug 2020 04:00:47 +0000 (00:00 -0400)]
docs: Improve the gallery image for scales

5 years agodocs: Add gallery images for some more widgets
Matthias Clasen [Tue, 4 Aug 2020 03:42:27 +0000 (23:42 -0400)]
docs: Add gallery images for some more widgets

This adds GtkPicture, GtkVideo, GtkMediaControls.

5 years agodocs: Regenerate widget gallery images
Matthias Clasen [Tue, 4 Aug 2020 03:41:49 +0000 (23:41 -0400)]
docs: Regenerate widget gallery images

5 years agodocs: Redo the doc shooter code
Matthias Clasen [Tue, 4 Aug 2020 01:09:54 +0000 (21:09 -0400)]
docs: Redo the doc shooter code

Steal snapshotting code from the reftests to
make this work again.

Other changes here: catch up with container removal.

5 years agoMerge branch 'pagesetup-leftover' into 'master'
Matthias Clasen [Tue, 4 Aug 2020 03:47:13 +0000 (03:47 +0000)]
Merge branch 'pagesetup-leftover' into 'master'

Pagesetup leftover

See merge request GNOME/gtk!2362

5 years agoMerge branch 'doc-links' into 'master'
Matthias Clasen [Tue, 4 Aug 2020 00:35:40 +0000 (00:35 +0000)]
Merge branch 'doc-links' into 'master'

Doc links

See merge request GNOME/gtk!2361

5 years agopagesetupdialog: Fix leftover tree model code
Matthias Clasen [Tue, 4 Aug 2020 00:23:59 +0000 (20:23 -0400)]
pagesetupdialog: Fix leftover tree model code

This was overlooked when the rest of the dialog
was ported to use list models.

5 years agodocs: Tweak documentation for list widgets
Matthias Clasen [Mon, 3 Aug 2020 22:41:36 +0000 (18:41 -0400)]
docs: Tweak documentation for list widgets

Fix numerous cases of : vs :: for signal references,
add some more details here and there.

5 years agodocs: Unify docs around incremental operations
Matthias Clasen [Mon, 3 Aug 2020 21:42:05 +0000 (17:42 -0400)]
docs: Unify docs around incremental operations

Sync up the wording around incremental filtering
and sorting to be more similar.

5 years agodocs: Fix signal references
Matthias Clasen [Mon, 3 Aug 2020 21:18:07 +0000 (17:18 -0400)]
docs: Fix signal references

It is :: for signals, : for properties, | for actions.

5 years agodocs: Fix typos
Matthias Clasen [Mon, 3 Aug 2020 21:17:56 +0000 (17:17 -0400)]
docs: Fix typos

5 years agodocs: Tell pandoc we need Docbook4
Matthias Clasen [Mon, 3 Aug 2020 20:53:44 +0000 (16:53 -0400)]
docs: Tell pandoc we need Docbook4

gtk-doc assumes Docbook4, with <ulink> and so on.
Without this, all the links in markdown are converted
to <link xlink:href=...> and then lost in the docbook->html
conversion.

5 years agodocs: Fix a typo
Matthias Clasen [Mon, 3 Aug 2020 20:53:32 +0000 (16:53 -0400)]
docs: Fix a typo

5 years agoUpdate Ukrainian translation
Yuri Chornoivan [Mon, 3 Aug 2020 17:02:11 +0000 (17:02 +0000)]
Update Ukrainian translation

5 years agoMerge branch 'patch-1' into 'master'
Matthias Clasen [Mon, 3 Aug 2020 16:22:19 +0000 (16:22 +0000)]
Merge branch 'patch-1' into 'master'

show: remove obsolete comment

See merge request GNOME/gtk!2359

5 years agoshow: remove obsolete comment
Alex [Mon, 3 Aug 2020 15:36:36 +0000 (15:36 +0000)]
show: remove obsolete comment

g_app_info_launch_default_for_uri supports x-scheme-handler directly since at least 2.27.1, released almost 10 years ago.

Link: https://bugzilla.gnome.org/show_bug.cgi?id=631410
Link: https://gitlab.gnome.org/GNOME/glib/-/commit/9b262f1c5fe5a6fd879f17cd7b80d8c54e33d80c
5 years agoMerge branch 'treeview-editing' into 'master'
Matthias Clasen [Mon, 3 Aug 2020 12:28:20 +0000 (12:28 +0000)]
Merge branch 'treeview-editing' into 'master'

treeview: Don't react to clicks on cell editables

Closes #3008

See merge request GNOME/gtk!2358

5 years agoci: Update subprojects
Matthias Clasen [Mon, 3 Aug 2020 12:11:03 +0000 (08:11 -0400)]
ci: Update subprojects

Otherwise, we end up stuck on old checkouts, and
bumping requirements lets to build failures.

5 years agotreeview: Don't react to clicks on cell editables
Matthias Clasen [Mon, 3 Aug 2020 11:49:31 +0000 (07:49 -0400)]
treeview: Don't react to clicks on cell editables

We need to let these pass through, otherwise we
interfere with the entries that are used for editing.

Fixes: #3008
5 years agoMerge branch 'filechoosernative-docs' into 'master'
Matthias Clasen [Mon, 3 Aug 2020 11:09:03 +0000 (11:09 +0000)]
Merge branch 'filechoosernative-docs' into 'master'

docs: Introspect GtkFileChooserNative info

Closes #2799

See merge request GNOME/gtk!2357

5 years agodocs: Introspect GtkFileChooserNative info
Matthias Clasen [Mon, 3 Aug 2020 04:13:10 +0000 (00:13 -0400)]
docs: Introspect GtkFileChooserNative info

We were missing gtk_file_chooser_native_get_type
in gtk4.types.in, causing introspected info to not
be included.

Fixes: #2799
5 years agoMerge branch 'applaunch-warning' into 'master'
Matthias Clasen [Mon, 3 Aug 2020 03:30:59 +0000 (03:30 +0000)]
Merge branch 'applaunch-warning' into 'master'

x11: Ignore stray DestroyNotify events

Closes #3006

See merge request GNOME/gtk!2355

5 years agorgba: Use pango_color_parse_with_alpha
Matthias Clasen [Mon, 3 Aug 2020 03:23:49 +0000 (23:23 -0400)]
rgba: Use pango_color_parse_with_alpha

Use this newly exported pango function, so we
can support hex colors with alpha like #rrggbbaa.

Fixes: #2931
5 years agoBump the pango dependency
Matthias Clasen [Mon, 3 Aug 2020 03:29:42 +0000 (23:29 -0400)]
Bump the pango dependency

Require pango 1.45.5, so we can use pango_color_parse_with_alpha.

5 years agox11: Ignore stray DestroyNotify events
Matthias Clasen [Mon, 3 Aug 2020 02:43:48 +0000 (22:43 -0400)]
x11: Ignore stray DestroyNotify events

There's no use in making a delete event with a
NULL surface. Just ignore such events.

Fixes: #3006
5 years agoMerge branch 'fishbowl-crash' into 'master'
Matthias Clasen [Mon, 3 Aug 2020 02:19:01 +0000 (02:19 +0000)]
Merge branch 'fishbowl-crash' into 'master'

Fishbowl crash

Closes #2996 and #3003

See merge request GNOME/gtk!2352

5 years agoMerge branch 'search-demo-fixes' into 'master'
Matthias Clasen [Mon, 3 Aug 2020 02:18:41 +0000 (02:18 +0000)]
Merge branch 'search-demo-fixes' into 'master'

Search demo fixes

Closes #3004

See merge request GNOME/gtk!2354

5 years agoMerge branch 'tagged-entry-demo' into 'master'
Matthias Clasen [Mon, 3 Aug 2020 02:18:28 +0000 (02:18 +0000)]
Merge branch 'tagged-entry-demo' into 'master'

gtk-demo: Simplify the tagged entry demo

Closes #3005

See merge request GNOME/gtk!2353

5 years agogtk-demo: Fix cleanup of search entry demo
Matthias Clasen [Mon, 3 Aug 2020 01:53:59 +0000 (21:53 -0400)]
gtk-demo: Fix cleanup of search entry demo

We can't use the ::destroy signal anymore; use
a weak ref instead, and make ensure the entry
stays around long enough for us to finish the
cleanup.

Fixes: #3004
5 years agogtk-demo: Make search progress visible again
Matthias Clasen [Mon, 3 Aug 2020 01:46:44 +0000 (21:46 -0400)]
gtk-demo: Make search progress visible again

Set a progress fraction, so that the pulsing progress
in the search entry demo is actually visible.

5 years agoMerge branch 'font-explorer-crash' into 'master'
Matthias Clasen [Mon, 3 Aug 2020 01:40:51 +0000 (01:40 +0000)]
Merge branch 'font-explorer-crash' into 'master'

gtk-demo: Avoid invalid OpenType feature tags

Closes #2962

See merge request GNOME/gtk!2351

5 years agoMerge branch 'emoji-insert-fix' into 'master'
Matthias Clasen [Mon, 3 Aug 2020 01:40:43 +0000 (01:40 +0000)]
Merge branch 'emoji-insert-fix' into 'master'

textview: Make insert-emoji replace the selection

Closes #2996

See merge request GNOME/gtk!2350

5 years agogtk-demo: Simplify the tagged entry demo
Matthias Clasen [Mon, 3 Aug 2020 01:38:25 +0000 (21:38 -0400)]
gtk-demo: Simplify the tagged entry demo

No need for an intermediate box widget here;
we can just use a box layout. As a side-effect,
this fixes the theme to apply to the selection.

Fixes: #3005
5 years agogdk: Fix gdk_surface_get_layout_monitor
Matthias Clasen [Mon, 3 Aug 2020 01:27:03 +0000 (21:27 -0400)]
gdk: Fix gdk_surface_get_layout_monitor

We are determining the monitor by maximizing the
intersection; that only works if our rectangle
is not empty.

Fixes: #3003
5 years agogtk-demo: Avoid invalid OpenType feature tags
Matthias Clasen [Mon, 3 Aug 2020 01:11:30 +0000 (21:11 -0400)]
gtk-demo: Avoid invalid OpenType feature tags

ss00 doesn't exist, and we use xxxx as placeholder
for 'default' choices in alternatives. Add a warning
in case we run across invalid OpenType feature tags
in fonts.

Fixes: #2962
5 years agotextview: Make insert-emoji replace the selection
Matthias Clasen [Mon, 3 Aug 2020 00:48:14 +0000 (20:48 -0400)]
textview: Make insert-emoji replace the selection

This is the expected behavior, and matches what
GtkText does.

Fixes: #2996
5 years agoMerge branch 'filechooser-completions' into 'master'
Matthias Clasen [Mon, 3 Aug 2020 00:23:28 +0000 (00:23 +0000)]
Merge branch 'filechooser-completions' into 'master'

filechooser: Prevent over-eager completions

Closes #2995

See merge request GNOME/gtk!2347

5 years agoMerge branch 'wip/chergert/gtk4-textview-fix-selections' into 'master'
Matthias Clasen [Mon, 3 Aug 2020 00:23:13 +0000 (00:23 +0000)]
Merge branch 'wip/chergert/gtk4-textview-fix-selections' into 'master'

textlinedisplaycache: short-circuit y_range invalidation

Closes #2975

See merge request GNOME/gtk!2348

5 years agoMerge branch 'fix-win32-ci' into 'master'
Matthias Clasen [Mon, 3 Aug 2020 00:19:43 +0000 (00:19 +0000)]
Merge branch 'fix-win32-ci' into 'master'

ci: Don't use --werror for the win32 build

See merge request GNOME/gtk!2349

5 years agoci: Don't use --werror for the win32 build
Matthias Clasen [Sun, 2 Aug 2020 23:59:25 +0000 (19:59 -0400)]
ci: Don't use --werror for the win32 build

This leads to warnings from the glib win32 build
failing our ci. Only use werror for gtk itself.

5 years agotextlinedisplaycache: short-circuit y_range invalidation
Christian Hergert [Sun, 2 Aug 2020 23:35:50 +0000 (16:35 -0700)]
textlinedisplaycache: short-circuit y_range invalidation

If we have a y==-1 then we are generally invalidating the whole textview.
For this case, we can just discard the entire GtkTextLineDisplay cache.

Fixes #2975

5 years agofilechooser: Prevent over-eager completions
Matthias Clasen [Sun, 2 Aug 2020 23:18:11 +0000 (19:18 -0400)]
filechooser: Prevent over-eager completions

We don't want the completions to pop up after we call
gtk_file_chooser_set_current_name(). This used to be
handled by gtk_entry_set_text() blocking the completion
signal handler. We don't have that anymore, so block
popup completion around the call to gtk_editable_set_text()
instead.

Fixes: #2995
5 years agoMerge branch 'grid-api' into 'master'
Matthias Clasen [Sun, 2 Aug 2020 23:17:40 +0000 (23:17 +0000)]
Merge branch 'grid-api' into 'master'

grid layout: Rename some properties

Closes #2967

See merge request GNOME/gtk!2345

5 years agobuilder-tool: Rewrite top/left-attach
Matthias Clasen [Sun, 2 Aug 2020 19:10:18 +0000 (15:10 -0400)]
builder-tool: Rewrite top/left-attach

Rewrite the GtkGrid:top/left-attach child properties
to the GtkGridLayoutChild:row/column layout properties.

Update expected test output to match.

5 years agogrid layout: Rename some properties
Matthias Clasen [Sun, 2 Aug 2020 18:13:14 +0000 (14:13 -0400)]
grid layout: Rename some properties

Rename GtkGridLayoutChild:left-attach/top-attach to
GtkGridLayoutChild:column/row. Update all users.

Fixes: #2967
5 years agoMerge branch 'fix-textiter-tests' into 'master'
Matthias Clasen [Sun, 2 Aug 2020 21:55:43 +0000 (21:55 +0000)]
Merge branch 'fix-textiter-tests' into 'master'

textbuffer: Fix a test failure

See merge request GNOME/gtk!2346

5 years agotextbuffer: Fix a test failure
Matthias Clasen [Sun, 2 Aug 2020 21:23:26 +0000 (17:23 -0400)]
textbuffer: Fix a test failure

The previous change to gtktextbuffer.c was breaking
the textiter testcase.

5 years agotextbuffer: Be careful with tags when copying
Matthias Clasen [Sun, 2 Aug 2020 17:54:06 +0000 (13:54 -0400)]
textbuffer: Be careful with tags when copying

We can only insert tags in the buffer if they come
from the same GtkTextTagTable as the buffer uses.
If that is not the case, paste the text without tags.

Fixes: #2991
5 years agoMerge branch 'text-drag-select' into 'master'
Matthias Clasen [Sun, 2 Aug 2020 17:45:30 +0000 (17:45 +0000)]
Merge branch 'text-drag-select' into 'master'

textview: Only claim the event when appropriate

Closes #2999

See merge request GNOME/gtk!2344

5 years agoMerge branch 'fallback-menu-critical' into 'master'
Matthias Clasen [Sun, 2 Aug 2020 17:42:22 +0000 (17:42 +0000)]
Merge branch 'fallback-menu-critical' into 'master'

popovermenu: Avoid a critical

Closes #2998

See merge request GNOME/gtk!2343

5 years agotextview: Only claim the event when appropriate
Matthias Clasen [Sun, 2 Aug 2020 17:31:15 +0000 (13:31 -0400)]
textview: Only claim the event when appropriate

Don't claim the event unconditionally for the click gesture,
since we may want to start a drag selection.

Fixes: #2999
5 years agopopovermenu: Avoid a critical
Matthias Clasen [Sun, 2 Aug 2020 17:09:00 +0000 (13:09 -0400)]
popovermenu: Avoid a critical

While we guarantee that the widget that a controller
is attached to stays around while it is handling an event,
the same is not true for the root that the widget belongs
to. In corner cases (such as clicking "Close" in the
fallback window menu), it may already be gone.
Avoid a critical in that case.

Fixes: #2998
5 years agoMerge branch 'selectable-label-draw' into 'master'
Matthias Clasen [Sun, 2 Aug 2020 16:40:12 +0000 (16:40 +0000)]
Merge branch 'selectable-label-draw' into 'master'

label: Redraw when focus changes

See merge request GNOME/gtk!2342

5 years agoMerge branch 'linked-button-fixes' into 'master'
Matthias Clasen [Sun, 2 Aug 2020 16:39:59 +0000 (16:39 +0000)]
Merge branch 'linked-button-fixes' into 'master'

Adwaita: Add linked styling for particular button widgets

Closes #2939 and #1903

See merge request GNOME/gtk!2339

5 years agoMerge branch 'controllers-list' into 'master'
Matthias Clasen [Sun, 2 Aug 2020 16:25:50 +0000 (16:25 +0000)]
Merge branch 'controllers-list' into 'master'

Controllers list

See merge request GNOME/gtk!2341

5 years agolabel: Redraw when focus changes
Matthias Clasen [Sun, 2 Aug 2020 15:24:27 +0000 (11:24 -0400)]
label: Redraw when focus changes

When focus changes in a selectable label, we need to
redraw to make the text caret (dis)appear.

5 years agoGo back to keeping a list of event controllers
Matthias Clasen [Sun, 2 Aug 2020 16:00:46 +0000 (12:00 -0400)]
Go back to keeping a list of event controllers

This reverts 4b9e5304cc1f675d2. It caused a number of regressions,
such as event controller ordering changes.

5 years agoRevert "Add gtk_widget_prepend_controller"
Matthias Clasen [Sun, 2 Aug 2020 15:54:29 +0000 (11:54 -0400)]
Revert "Add gtk_widget_prepend_controller"

This reverts commit 692cc42e1023ec439d2fa1a0b9456e8cbfe1cec8.

5 years agoRevert "entry completion: Make keynav work again"
Matthias Clasen [Sun, 2 Aug 2020 15:54:03 +0000 (11:54 -0400)]
Revert "entry completion: Make keynav work again"

This reverts commit 53a30eaa12e44a2ee5da7c9bc9a23a8bfeb733dc.

5 years agoMerge branch 'matthiasc/for-master' into 'master'
Matthias Clasen [Sun, 2 Aug 2020 15:05:17 +0000 (15:05 +0000)]
Merge branch 'matthiasc/for-master' into 'master'

shortcutswindow: Clear search entry on unmap

Closes #2981

See merge request GNOME/gtk!2340